Foundation: Support contextual theming and styles #5867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs to createComponent. Create examples to demo.
9 tasks
dzearing
reviewed
Aug 9, 2018
| // TODO: do we want field props? should fields be part of IComponentOptions and used here? | ||
| // TODO: should we centrally define DefaultFields? (not exported from styling) | ||
| const DefaultFields = ['theme', 'styles']; | ||
| return Customizations.getSettings(DefaultFields, displayName, context.customizations); |
There was a problem hiding this comment.
defaultfields are default... some components, like Layer, can mark additional fields as customizable (such as "hostId"). How is this piped in?
There was a problem hiding this comment.
Yeah, I wanted to talk to you about that. I have the TODO on line 106 for exactly that. 😄
dzearing
reviewed
Aug 9, 2018
| >({ | ||
| displayName: 'CollapsibleSection', | ||
| view: CollapsibleSectionView, | ||
| styles |
There was a problem hiding this comment.
customizableProps: ['foo', 'bar', 'baz']; maybe
There was a problem hiding this comment.
Yep, that's what I was thinking, assuming we still needed to pipe them in (tied to other comment)
dzearing
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Add support for contextual theming, styles, settings and scoped settings to createComponent. Create examples to demo.
There's a bit of engineering debt accruing here but seeing as we wanted something for Friday and I'm on Shield, we can either leave this open until issues are addressed or merge and follow up.
Focus areas to test
Tests to be written (aforementioned engineering debt.)
Microsoft Reviewers: Open in CodeFlow