Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer now uses React 16 context. (#5701) #6268

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Customizer now uses React 16 context. (#5701) #6268

merged 2 commits into from
Sep 7, 2018

Conversation

JasonGore
Copy link
Member

@JasonGore JasonGore commented Sep 7, 2018

Pull request checklist

Description of changes

Now that Layer uses React Portals (#6211), we can reintroduce React 16 Context (#5701) and not have it break Layered content (#6055).

screen shot 2018-09-06 at 5 20 27 pm

Focus areas to test

Microsoft Reviewers: Open in CodeFlow

* Moving Customizer to new React context.j

* adding change files.

* reversing change.

* Update package.json

* Fixing merge issue.

* Dropdown fixes.

* Fixes for foundation.

* Oops

* adding changes.
@JasonGore JasonGore merged commit 888f598 into microsoft:master Sep 7, 2018
JasonGore added a commit that referenced this pull request Sep 7, 2018
* Remove Object.assign usage inadvertently added by #6268.

* Change file.
@JasonGore JasonGore mentioned this pull request Sep 24, 2018
9 tasks
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading a new theme does not update components that return false on shouldComponentUpdate
3 participants