Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: propagate aria-label and aria-labelledby to options list #9003

Merged
merged 8 commits into from
May 28, 2019
Merged

Dropdown: propagate aria-label and aria-labelledby to options list #9003

merged 8 commits into from
May 28, 2019

Conversation

atneik
Copy link
Contributor

@atneik atneik commented May 8, 2019 •
edited by msft-github-bot
Loading

Pull request checklist

Description of changes

Fixed aria-labelledby so that FocusZone (which renders the listbox containing all options) correctly receives the attribute. Added aria-label to the FocusZone too.

Microsoft Reviewers: Open in CodeFlow

@atneik atneik requested a review from ecraig12345 as a code owner May 8, 2019 00:04
@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 8, 2019 •
edited
Loading

Component perf results:

Scenario Target branch avg total (ms) PR avg total (ms) Target branch avg per item (ms) PR avg per item (ms) Is significant change Is regression
PrimaryButton 76.015 78.408 0.760 0.784 false false
BaseButton 28.102 29.603 0.281 0.296 true true
NewButton 108.832 113.966 1.088 1.140 true true
button 4.523 4.831 0.045 0.048 true true
DetailsRows without styles 166.530 168.068 1.665 1.681 false false
DetailsRows 194.851 195.703 1.949 1.957 false false
Toggles 46.263 50.463 0.463 0.505 false false
NewToggle 66.314 65.375 0.663 0.654 false false
DocumentCardTitle with truncation 22.657 23.472 0.227 0.235 false false

@size-auditor
Copy link

size-auditor bot commented May 8, 2019 •
edited
Loading

Bundle test Size (minified) Diff from master
Dropdown 215.522 kB ExceedsBaseline     33 bytes
DetailsList 215.003 kB ExceedsBaseline     3 bytes
ShimmeredDetailsList 226.001 kB ExceedsBaseline     3 bytes

ExceedsTolerance  Exceeds Tolerance     ExceedsBaseline  Exceeds Baseline     BelowBaseline  Below Baseline     1 kB = 1000 bytes

@atneik atneik requested a review from JasonGore as a code owner May 9, 2019 23:17
@atneik atneik requested a review from KevinTCoughlin as a code owner May 15, 2019 02:27
@atneik atneik requested a review from joschect as a code owner May 15, 2019 21:33
@atneik atneik merged commit 0dde4ac into microsoft:master May 28, 2019
@msft-github-bot
Copy link
Contributor

🎉[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request May 29, 2019
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@KevinTCoughlin KevinTCoughlin KevinTCoughlin approved these changes

@joschect joschect joschect approved these changes

@JasonGore JasonGore JasonGore approved these changes

Assignees

@atneik atneik

Labels
Component: Dropdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdown does not propagate aria-labelledby in option list
6 participants
@atneik @msft-github-bot @KevinTCoughlin @ecraig12345 @joschect @JasonGore