Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable git update-git-for-windows #243

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

dscho
Copy link
Member

@dscho dscho commented Feb 4, 2020

This addresses #241

@dscho dscho requested a review from derrickstolee February 4, 2020 18:49
@dscho dscho force-pushed the disable-update-gfw branch from b47c509 to 29e756b Compare February 4, 2020 20:45
Copy link

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! So by making git update an actual builtin, the script version from git-for-windows/build-extra will never be visible? That seems like a good approach.

@dscho
Copy link
Member Author

dscho commented Feb 4, 2020

by making git update an actual builtin, the script version from git-for-windows/build-extra will never be visible?

Yep ;-)

If a user runs git update-git-for-windows, then they will upgrade to a
version that does not support microsoft/vfsforgit or microsoft/scalar.

Therefore, let's prevent this.

This addresses microsoft#241
@dscho dscho force-pushed the disable-update-gfw branch from 29e756b to b114c34 Compare February 4, 2020 21:06
@dscho dscho merged commit 9bf9e08 into microsoft:vfs-2.25.0 Feb 4, 2020
@dscho dscho deleted the disable-update-gfw branch February 4, 2020 23:32
derrickstolee added a commit to derrickstolee/scalar that referenced this pull request Feb 5, 2020
derrickstolee added a commit to microsoft/scalar that referenced this pull request Feb 5, 2020
…abled fetch-pack and block 'git update'

See microsoft/git#240 and microsoft/git#243.

Because of #320, we do not need to update the minimum Git version from `v2.25.0.vfs.1.1` even though we are packaging with `v2.25.0.vfs.1.3` now.
derrickstolee pushed a commit that referenced this pull request Feb 21, 2020
Disable `git update-git-for-windows`
derrickstolee pushed a commit that referenced this pull request Mar 17, 2020
Disable `git update-git-for-windows`
derrickstolee pushed a commit that referenced this pull request Mar 23, 2020
Disable `git update-git-for-windows`
dscho added a commit that referenced this pull request May 20, 2020
Disable `git update-git-for-windows`
dscho added a commit that referenced this pull request May 20, 2020
Disable `git update-git-for-windows`
derrickstolee pushed a commit that referenced this pull request Jun 1, 2020
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Jul 18, 2020
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Jul 27, 2020
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Jul 28, 2020
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Oct 6, 2020
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Nov 3, 2023
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Nov 3, 2023
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Nov 3, 2023
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Nov 8, 2023
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Nov 14, 2023
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Nov 20, 2023
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit that referenced this pull request Feb 27, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Apr 23, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Apr 23, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Apr 24, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Apr 29, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request May 14, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request May 14, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Jun 3, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Jul 17, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Jul 17, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Jul 18, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham pushed a commit that referenced this pull request Jul 23, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Jul 25, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham pushed a commit that referenced this pull request Jul 29, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Sep 18, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Sep 24, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Oct 8, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham pushed a commit that referenced this pull request Dec 3, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Dec 17, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Dec 18, 2024
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Jan 1, 2025
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Jan 1, 2025
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Feb 10, 2025
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
dscho added a commit that referenced this pull request Feb 27, 2025
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants