forked from git-for-windows/git
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable git update-git-for-windows
#243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b47c509
to
29e756b
Compare
derrickstolee
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! So by making git update
an actual builtin, the script version from git-for-windows/build-extra will never be visible? That seems like a good approach.
jrbriggs
approved these changes
Feb 4, 2020
Yep ;-) |
If a user runs git update-git-for-windows, then they will upgrade to a version that does not support microsoft/vfsforgit or microsoft/scalar. Therefore, let's prevent this. This addresses microsoft#241
29e756b
to
b114c34
Compare
derrickstolee
added a commit
to derrickstolee/scalar
that referenced
this pull request
Feb 5, 2020
See microsoft/git#240 and microsoft/git#243. Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee
added a commit
to microsoft/scalar
that referenced
this pull request
Feb 5, 2020
…abled fetch-pack and block 'git update' See microsoft/git#240 and microsoft/git#243. Because of #320, we do not need to update the minimum Git version from `v2.25.0.vfs.1.1` even though we are packaging with `v2.25.0.vfs.1.3` now.
derrickstolee
pushed a commit
that referenced
this pull request
Feb 21, 2020
Disable `git update-git-for-windows`
derrickstolee
pushed a commit
that referenced
this pull request
Mar 17, 2020
Disable `git update-git-for-windows`
derrickstolee
pushed a commit
that referenced
this pull request
Mar 23, 2020
Disable `git update-git-for-windows`
dscho
added a commit
that referenced
this pull request
May 20, 2020
Disable `git update-git-for-windows`
dscho
added a commit
that referenced
this pull request
May 20, 2020
Disable `git update-git-for-windows`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #241