Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to include Scalar CLI details #377

Merged
merged 11 commits into from
Jun 17, 2021

Conversation

derrickstolee
Copy link

I created these as fixup! commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

  • The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
  • The rest are small and explained by the body of the commit messages.
  • One non-fixup! commit adds the docs/ directory from microsoft/scalar, with some edits due to the C port of Scalar.

This set of edits does only minor edits to the README content,
including:

1. Word wrapping to 100 characters.
2. Updating the installation instructions to use v2.32.0.vfs.0.2
3. Replace uses of "Microsoft Git" with `microsoft/git`

Signed-off-by: Derrick Stolee <[email protected]>
These docs have been altered to fit the version implemented in C within
microsoft/git. This means in particular that the advanced.md file no
longer applied at all. Some other areas were removed or significantly
edited.

Signed-off-by: Derrick Stolee <[email protected]>
Add a section about how the Scalar CLI is included in microsoft/git.

Signed-off-by: Derrick Stolee <[email protected]>
Edit the explaination of why this fork exists and its relationship to
the GVFS protocol.

Signed-off-by: Derrick Stolee <[email protected]>
Add instructions to check `scalar version`.

Signed-off-by: Derrick Stolee <[email protected]>
Add "and the Scalar CLI" to the header of the README

Signed-off-by: Derrick Stolee <[email protected]>
Copy link

@jeffhostetler jeffhostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I made a few comments here and there, but all in all very nice.

Typo noticed by Johannes.

Signed-off-by: Derrick Stolee <[email protected]>
Typos and a reference to git-maintenance builtin.

Signed-off-by: Derrick Stolee <[email protected]>
@dscho
Copy link
Member

dscho commented Jun 17, 2021

Darn, there's the "unable to access global gitconfig: Permission denied" problem again. I guess I will have to prioritize fixing it.

But the PR looks good, I think it is ready.

Copy link

@ldennington ldennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry about the formatting here, Stolee. Was there a specific tool you used to limit to 100 chars/line?

Fix build-from-source instructions.

Signed-off-by: Derrick Stolee <[email protected]>
@derrickstolee
Copy link
Author

Ah sorry about the formatting here, Stolee. Was there a specific tool you used to limit to 100 chars/line?

@ldennington I just use VS Code and have this in my settings.json:

"editor.rulers": [74,80,100],

The 74,80 give me a ballpark of what's best for Git, but I can use 100 when appropriate for different scenarios.

@derrickstolee derrickstolee merged commit 57eeed4 into microsoft:vfs-2.32.0 Jun 17, 2021
@ldennington
Copy link

Ah sorry about the formatting here, Stolee. Was there a specific tool you used to limit to 100 chars/line?

@ldennington I just use VS Code and have this in my settings.json:

"editor.rulers": [74,80,100],

The 74,80 give me a ballpark of what's best for Git, but I can use 100 when appropriate for different scenarios.

Awesome, thanks!

derrickstolee added a commit that referenced this pull request Aug 3, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
derrickstolee added a commit that referenced this pull request Aug 3, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
derrickstolee added a commit that referenced this pull request Aug 5, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
dscho pushed a commit that referenced this pull request Aug 5, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
derrickstolee added a commit that referenced this pull request Aug 9, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
derrickstolee added a commit that referenced this pull request Aug 12, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
derrickstolee added a commit that referenced this pull request Aug 17, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
dscho pushed a commit that referenced this pull request Oct 30, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
derrickstolee added a commit that referenced this pull request Oct 30, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
derrickstolee added a commit that referenced this pull request Oct 31, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
derrickstolee added a commit that referenced this pull request Nov 4, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
derrickstolee added a commit that referenced this pull request Nov 10, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
derrickstolee added a commit that referenced this pull request Nov 15, 2021
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 12, 2022
… details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 19, 2022
… details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
… details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
… details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
… details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
… details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
… details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
… details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 25, 2022
… details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 25, 2022
… details

I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
dscho pushed a commit that referenced this pull request Feb 1, 2022
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
dscho pushed a commit that referenced this pull request Jun 17, 2022
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
dscho pushed a commit that referenced this pull request Jun 17, 2022
I created these as `fixup!` commits so they get squashed in the next major release rebase, but also so they can be reviewed commit-by-commit.

* The first is a doozy, adjusting line widths and otherwise updating some minor things here and there.
* The rest are small and explained by the body of the commit messages.
* One non-`fixup!` commit adds the `docs/` directory from `microsoft/scalar`, with some edits due to the C port of Scalar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants