Fixes for build-git-installers necessitated by changes in Git v2.48.0
#727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably in yet another patch to accommodate Meson (don't you love it now?) the spaces in the `GIT-VERSION-FILE` are now gone. Where before, its contents looked somewhat like this: GIT_VERSION = 2.48.1.vfs.0.0 they now look this this (note the removed spaces): GIT_VERSION=2.48.1.vfs.0.0 Well, so here is yet another other patch to accommodate Meson, so that we can finally get a pre-release of v2.48.1.vfs.0.0 out. Signed-off-by: Johannes Schindelin <[email protected]>
We need to require a newer Ubuntu version because Git fails to build with Ubuntu 16.04. This is needed because Ubuntu 16.04 apparently has a horribly outdated curl version and Git must at all cost drop support for it: 4c1b7e3 (Merge branch 'bc/drop-ancient-libcurl-and-perl', 2024-12-04). I just wish that at times pragmatism would beat ideology, but it's not to be had in this instance. Unfortunately, it requires a bit more than just changing the Ubuntu version, as the newer version would now ask interactively for the timezone while setting up the `tzdata` package. Signed-off-by: Johannes Schindelin <[email protected]>
Sadly, since 904339e (Introduce support for the Meson build system, 2024-12-06) the `Documentation/asciidoc.conf` file that `contrib/subtree/` relies on is no longer present by default because it has to be generated now. This is yet another other, _other_ change required to accommodate Meson. Signed-off-by: Johannes Schindelin <[email protected]>
mjcheetham
approved these changes
Feb 14, 2025
androidprodject
approved these changes
Feb 17, 2025
androidprodject
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactorings will continue until morale improves.
These refactorings required a couple of changes to get the release workflow to work again, otherwise there wouldn't have been any v2.48.1.vfs.0.0. Took me only 7 attempts and several choice words to those who require deployment workflows to be defined within the Git-tracked source code that is to be deployed.