Fix the release-winget workflow
#728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the workflow to strip the enclosing double quotes from the PAT. In a98c3d7 (fixup! Adding winget workflows, 2024-10-28), I converted the `release-winget` workflow from hard-coding the PAT that is required as a repository secret to retrieving it from an Azure KeyVault instead. However, I made a crucial mistake there: The `az keyvault` call outputs a JSON-formatted value by default. Using the "tab-separated value" format as we do elsewhere fixes the problem: There is only one value, therefore no tab will be inserted, and certainly no double quotes will surround the retrieved value. This bug prevented the workflow from running correctly, and Matthew had to follow the steps manually instead. Let's fix this so that next time, it will work without any hassle (apart from needing to recreate the PAT and storing it in the Key Vault because of the PAT's short-lived nature). Signed-off-by: Johannes Schindelin <[email protected]>
As we did elsewhere, use the `--output tsv` option of `az keyvault` to avoid having the retrieved value be enclosed in double quotes. Signed-off-by: Johannes Schindelin <[email protected]>
|
The |
derrickstolee
approved these changes
Feb 22, 2025
mjcheetham
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that caused all recent
release-wingetworkflow runs to fail.