remove AES cipher finalize call on tests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
approved these changes
Feb 22, 2022
| @@ -35,7 +35,6 @@ func TestNewGCMNonce(t *testing.T) { | |||
| if err != nil { | |||
| t.Errorf("expected no error for standard tag / nonce size, got: %#v", err) | |||
| } | |||
| c.finalize() | |||
There was a problem hiding this comment.
Should we add a test to explicitly test the finalizer? (runtime.SetFinalizer(c, nil) and run it manually in the test body?)
jaredpar
approved these changes
Feb 22, 2022
chsienki
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually calling
finalize()leads to double-freeing the cipher, which makes OpenSSL to panic.finalizeis not exported so there is no way this panic can be triggered from outside the library.This behavior hasn't been seen in CI tests because it is only triggered when the garbage collector calls the AES cipher finalizer, and our tests do not run long enough to start the gc.