all: increase test coverage #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
reviewed
Jan 25, 2022
openssl/aes_test.go
Outdated
| // is only available since go1.17. | ||
| // TODO: use math.MaxInt once go1.16 is no longer supported. | ||
| const intSize = 32 << (^uint(0) >> 63) // 32 or 64 | ||
| maxInt := 1<<(intSize-1) - 1 |
There was a problem hiding this comment.
Would bits.OnesCount(^uint(0)) be a clearer swap-in? (I imagine the extra dependency is ok here because it's test code.)
There was a problem hiding this comment.
I just realized this code is only using intSize to make maxInt... could use int((^uint(0)) >> 1)?
Co-authored-by: Davis Goodin <[email protected]>
dagood
approved these changes
Jan 31, 2022
chsienki
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the test coverage from ~30% to ~75%.
The new tests are mostly about calling OpenSSL functions and checking that there are no errors, that nothing panics, and, when possible, that encrypt/decrypt and sign/verify functions can roundtrip correctly.
This tests will help a lot on ensuring that there are no regressions in our OpenSSL support matrix once the CI is in place.
It is out of the scope of this PR, and probably from this repo, to ensure the cryptographic correctness for the exposed functions. This validation is not trivial is is very tied to how this package is integrated with the Go toolchain.