Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.1] Backport #34 - Initialize empty AES-GCM inputs #35

Merged
merged 3 commits into from
Aug 10, 2022
Merged

[v0.1] Backport #34 - Initialize empty AES-GCM inputs #35

merged 3 commits into from
Aug 10, 2022

Conversation

qmuntal
Copy link
Member

@qmuntal qmuntal commented Jul 29, 2022 •
edited
Loading

Backports #34 into v0.1 branch, which is used in go1.18 and earlier.

Cherry picked using:
git cherry-pick -x 56c115610dfb8ea9a6dd9370c10bfa4788225b8e a4dfee40e1f0e192ed857812723e5bd647911f63 5909954c5bb75de0921ee05c90ecdcf3c6ad9103

@qmuntal qmuntal requested review from dagood, chsienki and jaredpar July 29, 2022 07:44
dagood
dagood approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use git cherrypick for the commits? IMO it's good to include -x to generate the "(cherry picked from 56c1156)" bit, so it's easier to trace when viewing history.

@qmuntal
Copy link
Member Author

qmuntal commented Aug 1, 2022

Did you use git cherrypick for the commits? IMO it's good to include -x to generate the "(cherry picked from 56c1156)" bit, so it's easier to trace when viewing history.

Yep, I did us cherrypick, but didn't know about the -x parameter. I will revert and resubmit with -x.

qmuntal added 3 commits August 1, 2022 12:10
@qmuntal
initialize empty AES-GCM inputs
27dc62e 
(cherry picked from commit 56c1156)
@qmuntal
add AES-GCM empty inputs test
cb8ac74 
(cherry picked from commit a4dfee4)
@qmuntal
fix TestSealAndOpen_Empty
72499a6 
(cherry picked from commit 5909954)
@qmuntal qmuntal force-pushed the v0.1-backport-seal branch from bbd8d3b to 72499a6 Compare August 1, 2022 10:10
@qmuntal
Copy link
Member Author

qmuntal commented Aug 10, 2022

Submitting with one review as this is a clean backport.

@qmuntal qmuntal merged commit c59160c into v0.1 Aug 10, 2022
@qmuntal qmuntal deleted the v0.1-backport-seal branch August 10, 2022 12:56
@qmuntal qmuntal mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagood dagood dagood approved these changes

@chsienki chsienki Awaiting requested review from chsienki

@jaredpar jaredpar Awaiting requested review from jaredpar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qmuntal @dagood