Fix use-after-free and double-free bugs on ECDH keys #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
approved these changes
Jan 20, 2023
| // This also ensures that priv is not finalized meanwhile | ||
| // the public key is alive. | ||
| // | ||
| // We could avoid this altogether if using EVP_PKEY_up_ref |
There was a problem hiding this comment.
Suggested change
| // We could avoid this altogether if using EVP_PKEY_up_ref | |
| // We could avoid this altogether by using EVP_PKEY_up_ref |
Co-authored-by: Davis Goodin <[email protected]>
chsienki
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of memory issues produced when calling
PrivateKeyECDH.PublicKey().The underlying problem is that this method creates a public key that shares the same OpenSSL EVP_PKEY instance with the private key. This EVP_KEY is freed when any of the keys is garbage collected, leaving the other key with an invalid EVP_PKEY that will probably crash the application when it is used.
I've also improved the test pipeline so it has more chances to detect this memory bugs.