Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported version update #48

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Supported version update #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ On the other hand, Google maintains a branch that uses cgo and BoringSSL to impl

### Multiple OpenSSL versions supported

The `openssl` package has support for multiple OpenSSL versions, namely 1.0.1, 1.1.0, 1.1.1 and 3.0.2.
The `openssl` package has support for multiple OpenSSL versions, namely 1.0.2, 1.1.0, 1.1.1 and 3.0.2.
Copy link
Member

@dagood dagood Feb 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... should 3.0.2 be changed to 3.0.1 also, to match what CI tests? @qmuntal

go-crypto-openssl/.github/workflows/test.yml

Lines 9 to 10 in 2cec441

openssl-version-build: [1.0.2, 1.1.0, 1.1.1, 3.0.1]
openssl-version-test: [1.0.2, 1.1.0, 1.1.1, 3.0.1]

(This might also explain the typo--patch versions swapped between these two.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should support all OpenSSL 3.0 versions at once, in theory the new versioning policy forbides API breakages between patch versions. Having said this, it might be good to test with OpenSSL 3.0.0 and OpenSSL 3.0.8 (the latest at this moment).


All supported OpenSSL versions passes an small set of automatic tests that ensure they can be built and that there are no major regressions.
These tests do not validate the cryptographic correctness of the `openssl` package.
Expand Down