Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port "make" retry on Windows to main branch #387

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

dagood
Copy link
Member

@dagood dagood commented Jan 28, 2022

Port a0895e3 (#299) to microsoft/main to mitigate:


At the time of the original PR, Windows flakiness was only showing up in the 1.17 branch, so this feature was implemented there. But, I saw it in microsoft/main while working on the migration to submodules:

go install cmd/link: copying
  C:\Users\VSSADM~1\AppData\Local\Temp\go-build2884892749\b164\exe\a.out.exe:
  open D:\a\1\s\go\pkg\tool\windows_amd64\link.exe: Access is denied.

https://dev.azure.com/dnceng/internal/_build/results?buildId=1574835&view=logs&j=b5927786-9a30-525e-205c-cd8ea15c1825&s=96ac2280-8cb4-5df5-99de-dd2da759617d&t=f7c1727d-5b14-5ff4-8b2e-08087f80ab99&l=86

(Technically link.exe rather than compile.exe, but it seems likely to be the same root cause.)

@dagood dagood requested a review from a team as a code owner January 28, 2022 01:23
@dagood
Copy link
Member Author

dagood commented Jan 28, 2022

Enabling auto-merge to merge with one reviewer: simple/clean port.

@dagood dagood enabled auto-merge (squash) January 28, 2022 19:30
@dagood
Copy link
Member Author

dagood commented Jan 28, 2022

@microsoft/golang-compiler PTAL, porting Windows unreliability mitigation forward to main.

@dagood dagood merged commit 15da08e into microsoft/main Jan 31, 2022
@dagood dagood deleted the dev/dagood/win-make-retry branch January 31, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants