fix: relax check in transform plugin #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem from microsoft/fluentui#25216.
griffel/packages/babel-preset/src/transformPlugin.ts
Lines 44 to 46 in b360b56
The check that we have currently is too strict and breaks legit cases:
This PR simplifies it to match returned types. The test was removed as I can't build a compilable code to throw there:
t.callExpression
acceptsArray<Expression | SpreadElement | JSXNamespacedName | ArgumentPlaceholder>
, but I can't imagine/create a case whenJSXNamespacedName | ArgumentPlaceholder
will be arguments.