-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use onnxmltools>=1.6.0,<=1.11.0
instead of onnxmltools>=1.6.0
#592
Conversation
Codecov Report
@@ Coverage Diff @@
## main #592 +/- ##
==========================================
+ Coverage 80.47% 90.30% +9.82%
==========================================
Files 78 78
Lines 4569 4569
Branches 948 948
==========================================
+ Hits 3677 4126 +449
+ Misses 723 252 -471
- Partials 169 191 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
onnxmltools>=1.6.0,<=1.11.0
instead of onnxmltools>=1.6.0
This is great, thank you for finding the issue!! Not even related to your PR/TVM, but just unlucky timing. This work for me (back to 90%), what do you think @interesaaat ? |
This is great, thanks for finding this. Let's merge it. |
bed9ebb
to
79606f5
Compare
We had to pin it to that exact version of skltoonnx because of #533. :( I see that when you merged it, it passed on python 3.7 but failed on python 3.8? I'm confused how it passed before... was it bumping to skl==1.1.1 that broke things for you? Meaning, if you set everything back to f452692, is it ok then? |
31d4c3c
to
f452692
Compare
because `import onnxmltools` will fail with `onnxconverter_common==1.8.1`&`onnxmltools==1.11.1`
b2e83c9
to
3461aef
Compare
On Python 3.7, |
I think bumping to skl==1.1.1 broke something. With skl==1.0.2, CI has passed. Should we revert 2fe2e35? |
Another option is that we first go back to skl=1.0.2, then merge this commit. After that bump to skl=1.1.0. |
Thanks so much for all the time you put into this; I really appreciate it! I don't want to revert the last commit entirely because it had fixes we'll need moving forward, but we can definitely go back to skl1.0.2 for now. |
import onnxmltools
will fail withonnxconverter_common==1.8.1
&onnxmltools==1.11.1
. The failure caused ONNX test skipping.In this PR, we'll use
onnxmltools>=1.6.0,<=1.11.0
instead ofonnxmltools>=1.6.0
.Fix #589