Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Windows runner version #665

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Updating Windows runner version #665

merged 1 commit into from
Dec 22, 2022

Conversation

mshr-h
Copy link
Collaborator

@mshr-h mshr-h commented Dec 19, 2022

@mshr-h mshr-h force-pushed the update-windows-os-ver branch from cbe0edf to 1cd8a5e Compare December 20, 2022 12:18
@mshr-h mshr-h force-pushed the update-windows-os-ver branch from 1cd8a5e to 78e17d0 Compare December 21, 2022 02:06
@mshr-h mshr-h mentioned this pull request Dec 21, 2022
Closed
2 tasks
@mshr-h mshr-h changed the title Updating Windows runner OS Updating Windows runner version Dec 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022 •
edited
Loading

Codecov Report

Merging #665 (78e17d0) into main (e59b9fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          78       78           
  Lines        4543     4543           
  Branches      839      839           
=======================================
  Hits         4100     4100           
  Misses        252      252           
  Partials      191      191
Flag Coverage Δ
unittests 90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mshr-h mshr-h marked this pull request as ready for review December 21, 2022 02:42
@mshr-h
Copy link
Collaborator Author

mshr-h commented Dec 21, 2022

Should be good.

@ksaur @interesaaat
Can you review it? Thanks!

@mshr-h mshr-h requested review from interesaaat and ksaur December 21, 2022 02:44
@interesaaat
Copy link
Collaborator

Why there is still 2019 in the CI/CD pipeline? It looks that it is stuck there.

@interesaaat
Copy link
Collaborator

LGTM but I am not sure if the windows 2019 checks will also block on main.

@interesaaat
Copy link
Collaborator

Ok solved.

@interesaaat interesaaat merged commit 41aae4b into microsoft:main Dec 22, 2022
@mshr-h mshr-h deleted the update-windows-os-ver branch December 22, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@interesaaat interesaaat interesaaat approved these changes

@ksaur ksaur Awaiting requested review from ksaur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshr-h @codecov-commenter @interesaaat