fix jdt bug of ObjectCollectedException on ExceptionRequest.enable. (#…

…173)
microsoft · Apr 25, 2018 · 42f857e · 42f857e
1 parent 27d64e8
commit 42f857e
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/DebugSession.java b/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/DebugSession.java
@@ -89,6 +89,19 @@ public void setExceptionBreakpoints(boolean notifyCaught, boolean notifyUncaught
         manager.deleteEventRequests(legacy);
         // When no exception breakpoints are requested, no need to create an empty exception request.
         if (notifyCaught || notifyUncaught) {
+            // from: https://www.javatips.net/api/REPLmode-master/src/jm/mode/replmode/REPLRunner.java
+            // Calling this seems to set something internally to make the
+            // Eclipse JDI wake up. Without it, an ObjectCollectedException
+            // is thrown on request.enable(). No idea why this works,
+            // but at least exception handling has returned. (Suspect that it may
+            // block until all or at least some threads are available, meaning
+            // that the app has launched and we have legit objects to talk to).
+            vm.allThreads();
+            // The bug may not have been noticed because the test suite waits for
+            // a thread to be available, and queries it by calling allThreads().
+            // See org.eclipse.debug.jdi.tests.AbstractJDITest for the example.
+
+            // get only the uncaught exceptions
             ExceptionRequest request = manager.createExceptionRequest(null, notifyCaught, notifyUncaught);
             request.setSuspendPolicy(EventRequest.SUSPEND_EVENT_THREAD);
             request.enable();