Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Setup CI #5

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

chore: Setup CI #5

wants to merge 9 commits into from

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Jan 22, 2025

  • Configures sub-packages to depend on each other locally
  • Installs monorepo-builder which has valuable tools to manage monorepo e.g. validating dependencies are similar across packages
  • Streamlines package dependencies
  • Adds build workflows & dependabot configuration
  • Updates README to reflect changes

part of microsoft/kiota-abstractions-php#156

@Ndiritu Ndiritu self-assigned this Jan 22, 2025
@Ndiritu Ndiritu marked this pull request as ready for review January 22, 2025 10:22
@Ndiritu Ndiritu requested a review from a team as a code owner January 22, 2025 10:22
@Ndiritu Ndiritu marked this pull request as draft January 22, 2025 10:23
Ndiritu pushed a commit that referenced this pull request Jan 22, 2025
…abot/fetch-metadata-2.1.0

Bump dependabot/fetch-metadata from 2.0.0 to 2.1.0
@Ndiritu Ndiritu changed the base branch from chore/init-packages to main January 22, 2025 12:55
@Ndiritu Ndiritu force-pushed the chore/setup-ci branch 2 times, most recently from 0adb2d2 to 1d69ca2 Compare January 22, 2025 12:58
@Ndiritu Ndiritu marked this pull request as ready for review January 23, 2025 07:07
@Ndiritu
Copy link
Contributor Author

Ndiritu commented Jan 23, 2025

@baywet I think the coverage workflow is failing because the SONAR_TOKEN may be missing from the repo. Is it possible to configure this?

@musale
Copy link

musale commented Jan 23, 2025

@baywet I think the coverage workflow is failing because the SONAR_TOKEN may be missing from the repo. Is it possible to configure this?

I assume you can JIT into the repo and add the token.

@baywet
Copy link
Member

baywet commented Jan 23, 2025

yes, however the sonarcloud project needs to be created first, I opened a request here https://github.com/microsoft/github-operations/issues/639

@baywet
Copy link
Member

baywet commented Jan 24, 2025

Project was created by OSPO. I added the secret to this repo and made Philip an admin of the SonarCloud project as well.
Now the CI is failing with the following error
ERROR You must define the following mandatory properties for 'Unknown': sonar.projectKey, sonar.organization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants