Merge pull request #36 from microsoft/dev

v0.5.1
microsoft · Jun 12, 2023 · fb999ab · fb999ab
2 parents f53bed9 + 631212e
commit fb999ab
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/auto-merge-dependabot.yml b/.github/workflows/auto-merge-dependabot.yml
@@ -19,7 +19,7 @@ jobs:
     steps:
       - name: Dependabot metadata
         id: metadata
-        uses: dependabot/fetch-metadata@v1.4.0
+        uses: dependabot/fetch-metadata@v1.5.1
         with:
           github-token: "${{ secrets.GITHUB_TOKEN }}"
 

diff --git a/.github/workflows/pr-validation.yml b/.github/workflows/pr-validation.yml
@@ -15,7 +15,7 @@ jobs:
         php-versions: ['7.4', '8.0', '8.1', '8.2']
     steps:
       - name: Checkout
-        uses: actions/[email protected].2
+        uses: actions/[email protected].3
       - name: Setup PHP and Xdebug for Code Coverage report
         uses: shivammathur/setup-php@v2
         with:

diff --git a/src/JsonSerializationWriter.php b/src/JsonSerializationWriter.php
@@ -100,7 +100,7 @@ public function writeDateTimeValue(?string $key, ?DateTime $value): void {
             if (!empty($key)) {
                 $this->writePropertyName($key);
             }
-            $this->writePropertyValue($key, "\"{$value->format(DateTimeInterface::RFC3339)}Z\"");
+            $this->writePropertyValue($key, "\"{$value->format(DateTimeInterface::RFC3339)}\"");
         }
     }
 

diff --git a/tests/JsonSerializationWriterTest.php b/tests/JsonSerializationWriterTest.php
@@ -183,10 +183,10 @@ public function testWriteIntegerValue(): void {
         $this->assertEquals($expected, $actual);
     }
 
-    public function testWriteDateTimeOffsetValue(): void {
+    public function testWriteDateTimeValue(): void {
         $this->jsonSerializationWriter = new JsonSerializationWriter();
-        $this->jsonSerializationWriter->writeAnyValue("dateTime", new \DateTime('2018-12-12T12:34:42+00:00Z'));
-        $expected = '"dateTime":"2018-12-12T12:34:42+00:00Z"';
+        $this->jsonSerializationWriter->writeAnyValue("dateTime", new \DateTime('2018-12-12T12:34:42+00:00'));
+        $expected = '"dateTime":"2018-12-12T12:34:42+00:00"';
         $actual = $this->jsonSerializationWriter->getSerializedContent()->getContents();
         $this->assertEquals($expected, $actual);
     }