Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deserializing objects to stream #22

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Mar 22, 2023

When making batch requests, we need to deserialize an individual JSON response payload to a stream in the BatchResponseItem. We store the payload as a stream as we don't know the correct type to deserialize to beforehand.

@Ndiritu Ndiritu self-assigned this Mar 22, 2023
@Ndiritu Ndiritu marked this pull request as draft March 22, 2023 21:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@Ndiritu Ndiritu marked this pull request as ready for review March 22, 2023 21:24
@Ndiritu Ndiritu merged commit c2172fb into dev Apr 13, 2023
@Ndiritu Ndiritu deleted the fix/stream-deserialization branch April 13, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants