Refactor code to never do casts

[SilasKenneth]

Given the code

if ($parseNode->getBooleanValue() !== null) {
    $result->setBoolean($parseNode->getBooleanValue());
} else if ($parseNode->getFloatValue() !== null) {
    $result->setDouble($parseNode->getFloatValue());
} else if ($parseNode->getIntegerValue() !== null) {
    $result->setInteger($parseNode->getIntegerValue());
} else if ($parseNode->getStringValue() !== null) {
    $result->setString($parseNode->getStringValue());
}

With the current ParseNode implementation, the code will always never go to other branches of the if (unless getBooleanValue() returns null) since anything can be cast to boolean making the first branch of the if always true.

This work is part of
microsoft/kiota#2827
#73

[andrueastman]

Do we also need a changelog entry and version bump here?

[SilasKenneth]

Do we also need a changelog entry and version bump here?

Hi @andrueastman , this is done.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud