Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file type should be mapped as a binary type #221

Closed
baywet opened this issue Jun 7, 2021 · 0 comments · Fixed by #1565
Closed

file type should be mapped as a binary type #221

baywet opened this issue Jun 7, 2021 · 0 comments · Fixed by #1565
Assignees
@baywet
Labels
CLI Work to support generating CLIs with Kiota Csharp Pull requests that update .net code generator Issues or improvements relater to generation capabilities. Go Java type:bug A broken experience TypeScript Pull requests that update Javascript code
Milestone
Complete Graph AP...

Comments

@baywet
Copy link
Member

baywet commented Jun 7, 2021 •
edited by azure-boards bot
Loading

A parameter of type "file" is in fact a binary type with metadata.
The metadata include the name (which maps to the parameter/property name), the filename (string) and the MIME-type (content-type, string)

These parameter types should add an additional class with the required properties and map the property to that class.
Depends on #220

more reading
originally reported
AB#9789
@baywet baywet added the type:bug A broken experience label Jun 7, 2021
@baywet baywet added this to the Beta milestone Jun 7, 2021
@baywet baywet self-assigned this Jun 7, 2021
baywet added a commit that referenced this issue Jun 7, 2021
@baywet
- partial #219, #220, #221 excludes unsupported request content types…
97da252 
… via configuration
@baywet baywet mentioned this issue Jun 7, 2021
Closed
4 tasks
@baywet baywet added Java generator Issues or improvements relater to generation capabilities. Csharp Pull requests that update .net code TypeScript Pull requests that update Javascript code labels Jul 21, 2021
@baywet baywet mentioned this issue Aug 30, 2021
Closed
@baywet baywet added CLI Work to support generating CLIs with Kiota Go labels Nov 29, 2021
@RabebOthmani RabebOthmani moved this to Todo in Kiota Jan 24, 2022
@baywet baywet mentioned this issue Feb 14, 2022
Closed
baywet added a commit that referenced this issue May 16, 2022
@baywet
- fixes #221 adds support for file generation type
f114c81 
Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet mentioned this issue May 16, 2022
Merged
Repository owner moved this from Todo to Done in Kiota May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
CLI Work to support generating CLIs with Kiota Csharp Pull requests that update .net code generator Issues or improvements relater to generation capabilities. Go Java type:bug A broken experience TypeScript Pull requests that update Javascript code
Projects
Kiota
Archived in project
Milestone
Complete Graph API Surface support
Development

Successfully merging a pull request may close this issue.

excludes additional types for CSharp to avoid collision microsoft/kiota
2 participants
@darrelmiller @baywet