-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move middleware and other generic components from graph core to the http core library #360
Comments
Hey @baywet, I'm not sure if we really want to add an authorization handler in the kiota http core library by default. This is because,
|
@andrueastman you are correct, this issue was written before we revamped the authentication provider interface. In general I don't think having the authentication middleware is a good idea: it ties the authentication concern with a specific implementation of "transport" (http, with a specific client), which goes against our separation of concerns principles. I think we can skip this one, thanks for putting together the PRs for the other ones, I'll look into it ASAP. |
No worries. Thanks for clearing that up @baywet 😄 |
Closing this for now. |
Looking at the sdk-design features list, there are a number of component that exist today in the graph core library which belong to the kiota http core library.
Most of those components are the middlewares.
If they exist, move the following components:
authorization handler(see comment)AB#10325
The text was updated successfully, but these errors were encountered: