-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes a bug where a null schema would make the generation process derail #185
Conversation
Kudos, SonarCloud Quality Gate passed! |
Thanks @baywet - as in the screen shot above, I gave it a quick try but couldn't stay awake 💤 So you beat me to it :) |
@baywet - i was just playing with this PR on localhost and the "petstore" still fails with an exception.
I'm assuming that Kiota should work against the "petstore" json file? (looks like this section is failing?? ) EDIT: this was the command I used, which can be used to repo this:
|
Interestingly, when I try processing Petstore I'm getting a different issue: else throw new InvalidOperationException("un handled case, might be object type or array type");
// object type array of object are technically already handled in properties but if we have a root with those we might be missing some cases here this is caused by Pets:
type: array
items:
$ref: "#/components/schemas/Pet" We haven't run into this case with Graph OpenAPI descriptions because OData never allows an array at the root of a response. |
Should it be handled? Should the "petshop" be a valid sample that should generate? |
@PureKrome Sorry if that wasn't clear. Absolutely it should be handled. We should handle any valid OpenAPI doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
partial #135