Feature/http language support #5778
Open
+1,483
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crosoft/kiota into feature/http-language-support
baywet
requested changes
Jan 17, 2025
| var pathParameters = requestBuilderClass | ||
| .GetChildElements(true) | ||
| .OfType<CodeProperty>() | ||
| .Where(property => property.IsOfKind(CodePropertyKind.PathParameters) && !property.Name.Equals("pathParameters", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Then use a constant reference instead please
| namespace Kiota.Builder.Writers.Http; | ||
| public class CodePropertyWriter(HttpConventionService conventionService) : BaseElementWriter<CodeProperty, HttpConventionService>(conventionService) | ||
| { | ||
| public override void WriteCodeElement(CodeProperty codeElement, LanguageWriter writer) |
There was a problem hiding this comment.
Can we at least make a generic NO-OP writer, that we could reuse, to avoid the duplication?
…crosoft/kiota into feature/http-language-support
calebkiage
reviewed
Jan 20, 2025
…crosoft/kiota into feature/http-language-support
baywet
reviewed
Jan 20, 2025
baywet
reviewed
Jan 20, 2025
baywet
reviewed
Jan 20, 2025
added 2 commits
January 20, 2025 21:36
- Use TryGet to avoid reference resolution errors
baywet
reviewed
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for HTTP snippet generation as a language option.
Closes #5761 #5546 #5568 #5543