fix: use a subdirectory of the output path to reduce the chances of c… #6038
+28
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lean output deleting user code
baywet
requested changes
Jan 20, 2025
There was a problem hiding this comment.
This is a major change in behaviour that's going to surprise most consumers out there as demonstrated by the changes you had to implement in the compare-generation script.
I don't think we should ship that as is, maybe this is more of an experience aspect in the extension itself.
|
@baywet, how would you suggest we solve the P0 bug this is meant to address? |
|
I have provided details on the issue directly #5977 (comment) |
|
Given the updated requirements on #5977 (comment), I'll close this issue and open a new one with changes to the extension |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lean output deleting user code
closes #5977