Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename symbol should allow optional rename of file #41

Closed
joshtynjala opened this issue Jul 25, 2016 · 4 comments
Closed

Rename symbol should allow optional rename of file #41

joshtynjala opened this issue Jul 25, 2016 · 4 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Milestone
4.0

Comments

@joshtynjala
Copy link
Contributor

Some languages require the file name to match the name of the class, interface, or other symbol that the file contains. Renaming a symbol should optionally allow its file to be renamed too.
@joshtynjala joshtynjala mentioned this issue Jul 29, 2016
Closed
@dbaeumer
Copy link
Member

Agree. Besides having this in the protocol we need to have support in the vscode API as well. I opened microsoft/vscode#10659

@dbaeumer dbaeumer added this to the 3.0 milestone Aug 18, 2016
@gorkem gorkem mentioned this issue Aug 18, 2016
Closed
@gorkem gorkem mentioned this issue Feb 28, 2017
Closed
@dbaeumer dbaeumer modified the milestones: Backlog, 4.0 Apr 12, 2017
@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Apr 12, 2017
@Trolldemorted
Copy link

Any news for this? I guess the majority of programming languages have such constraints on the filename (java, python, rust, ...), and proper renaming cannot be implemented without file renaming support.

@Trolldemorted Trolldemorted mentioned this issue Jun 30, 2017
Closed
@dbaeumer dbaeumer modified the milestones: 4.0, Backlog Jul 13, 2017
@rcjsuen rcjsuen mentioned this issue Jul 21, 2017
Closed
@mickaelistria
Copy link

Dealing w/ moved/deleted files is not only useful for rename but might be useful for more refactorings. Fixing #272 which is on WorkspaceEdit in general would fix this one.

@dbaeumer
Copy link
Member

Closing in favor of #272

@dbaeumer dbaeumer added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
4 participants
@joshtynjala @mickaelistria @dbaeumer @Trolldemorted