WorkspaceEdit and File Level Operations

[tsmaeder]

A rename operation, for example returns a WorkspaceEdit operation. However, when renaming a Java class, for example, I expect the file to be renamed as well. Is there a way to express that in LSP?

[rcjsuen]

See also #41 and #191.

[mickaelistria]

What about a simple delete: true flag to mark the previous file as deleted (flag to be added to protocol) + a regular TextEdit with whole content of the new file?

[dbaeumer]

I agree that we should expand the WorkspaceEdit with a resourceChanges property which allows for the following resource operations:

• create (with content)
• move (includes rename)
• delete

This would solve the rename refactoring as as well.

[dbaeumer]

A proposal is highly appreciated.

[gorkem]

@dbaeumer I think this one needs a proposal-provided label also

[dbaeumer]

Agree.

[tsmaeder]

@dbaeumer I have seen there is support for resource change now in LSP. However, what's missing from my point of view is the creation of folders. If I have a rename or a delete, I know whether I am dealing with a folder or a file, But in a create, I have no way of knowing. Shouldn't "isFolder" be added to CreateFileOptions? The spec even references the possiblity to change folders, but it's not in the code.

[dbaeumer]

@tsmaeder correct :-). All I can recommend right now is to create a file in the folder and then delete the file.

I will keep the request open to support creating a folder. Will very likely be an additional property / param type: 'file' | 'folder'

[dbaeumer]

See also microsoft/vscode#62663

[yaohaizh]

@dbaeumer
For the workaround, on my windows' desktop, I always disabled recycle bin support. So the work around will pop up with text Failed to move 'fakeFile' to the recycle bin
This workaround is kind of issue if customer doesn't support recycle bin or have to enable options files.enableTrash: false

Either way, it is not decent workaround at this time.

[testforstephen]

Refactor package name is really an important feature for Java language, without creating/deleting folder support in LSP level, it's hard to bring this feature to jdt.ls.

@dbaeumer is there any update about this issue? Or any help i can provide to solve it? thanks.

[dbaeumer]

@testforstephen thanks for offering your help. Things needed to be done to make this work:

• extend LSP to provide a createFolder resource change
• to be able to leverage this in VS Code the API must be extended as well (see: https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L2870 and API should support to create a folder vscode#62663)

Should not be too complicated. I would start with the VS Code work and then add the LSP resource change.

[testforstephen]

great, thanks for the explanation. Looking forward to see it's solved.

[dbaeumer]

This got added a while back ago.