Fix a TreeViewItemAutomationPeer crash (#1449)

* Fix TreeViewItemAutomationPeer * CR feedback
microsoft · Oct 16, 2019 · 102ae5c · 102ae5c
1 parent ab66b66
commit 102ae5c
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/dev/TreeView/TreeViewItemAutomationPeer.cpp b/dev/TreeView/TreeViewItemAutomationPeer.cpp
@@ -114,15 +114,17 @@ int32_t TreeViewItemAutomationPeer::GetPositionInSetCore()
 {
     winrt::ListView ancestorListView = GetParentListView();
     auto targetNode = GetTreeViewNode();
-    int positionInSet = -1;
+    int positionInSet = 0;
 
     if (ancestorListView && targetNode)
     {
-        auto targetParentNode = targetNode.Parent();
-        UINT32 position = 0;
-        if (targetParentNode.Children().IndexOf(targetNode, position))
+        if (const auto targetParentNode = targetNode.Parent())
         {
-            positionInSet = static_cast<int>(position) + 1;
+            UINT32 position = 0;
+            if (targetParentNode.Children().IndexOf(targetNode, position))
+            {
+                positionInSet = static_cast<int>(position) + 1;
+            }
         }
     }
 
@@ -133,13 +135,15 @@ int32_t TreeViewItemAutomationPeer::GetSizeOfSetCore()
 {
     winrt::ListView ancestorListView = GetParentListView();
     auto targetNode = GetTreeViewNode();
-    int setSize = -1;
+    int setSize = 0;
 
     if (ancestorListView && targetNode)
     {
-        auto targetParentNode = targetNode.Parent();
-        UINT32 size = targetParentNode.Children().Size();
-        setSize = static_cast<int>(size);
+        if (const auto targetParentNode = targetNode.Parent())
+        {
+            UINT32 size = targetParentNode.Children().Size();
+            setSize = static_cast<int>(size);
+        }
     }
 
     return setSize;