Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing NavigationView's PaneDisplayMode also raises SelectionChanged event #148

Closed
2 of 11 tasks
YuliKl opened this issue Jan 7, 2019 · 0 comments · Fixed by #1956
Closed
2 of 11 tasks

Changing NavigationView's PaneDisplayMode also raises SelectionChanged event #148

YuliKl opened this issue Jan 7, 2019 · 0 comments · Fixed by #1956
Labels
area-NavigationView NavView control bug Something isn't working team-Controls Issue for the Controls team

Comments

@YuliKl
Copy link

YuliKl commented Jan 7, 2019

Describe the bug

When NavigationView changes its PaneDisplayMode between Auto and Top, it also raises a SelectionChanged event, even though the selected item was not modified. This is problematic when the currently selected item is Settings, because the event args incorrectly report IsSettingsSelected as false.

Steps to reproduce the bug

  1. Run sample project: NavigationViewPaneModeApp.zip
  2. Click Settings
  3. Click "Change Pane Mode" button

Expected behavior

The NavigationView should change its orientation from vertical to horizontal, or vice versa, while keeping the Settings item selected.

What's actually happening is that the app is crashing on trying to access the content of the selected item, which is null.

Screenshots

Version Info

NuGet package version:

Microsoft.UI.Xaml 2.1.181217001-preview

Windows 10 version:

  • Insider Build (xxxxx)

  • October 2018 Update (17763)

  • April 2018 Update (17134)

  • Fall Creators Update (16299)

  • Creators Update (15063)

  • Anniversary Update (14393)

Device form factor:

  • Desktop
  • Mobile
  • Xbox
  • Surface Hub
  • IoT

Additional context
@YuliKl YuliKl added bug Something isn't working area-NavigationView NavView control labels Jan 7, 2019
YuliKl pushed a commit to microsoft/WinUI-Gallery that referenced this issue Jan 7, 2019
Added null check to prevent app from crashing. Also opened WinUI issue (
b5d75e9 
microsoft/microsoft-ui-xaml#148).
@YuliKl YuliKl mentioned this issue Jan 7, 2019
Merged
3 tasks
stmoy pushed a commit to microsoft/WinUI-Gallery that referenced this issue Jan 8, 2019
@stmoy
Added null check to NavigationView sample to prevent app from crashing
59dbaea 
Also opened WinUI issue (microsoft/microsoft-ui-xaml#148). (#24)
marcelwgn added a commit to marcelwgn/microsoft-ui-xaml that referenced this issue Oct 1, 2019
@marcelwgn
Add unit test for microsoft#148
fb6f7b4
@marcelwgn marcelwgn mentioned this issue Oct 1, 2019
Closed
marcelwgn added a commit to marcelwgn/microsoft-ui-xaml that referenced this issue Oct 15, 2019
@marcelwgn
Add unit test for microsoft#148
e5cae29
@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
@marcelwgn marcelwgn mentioned this issue Feb 8, 2020
Merged
@ad1Dima ad1Dima mentioned this issue Feb 20, 2020
Merged
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label May 17, 2020
@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-NavigationView NavView control bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
4 participants
@StephenLPeters @YuliKl @jevansaks @msft-github-bot