Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabView now enforces hard minimum and maximum 40, 250 in all sizing modes #1481

Closed
DHowett-MSFT opened this issue Oct 23, 2019 · 5 comments
Closed
Assignees
Labels
area-TabView help wanted Issue ideal for external contributors team-Controls Issue for the Controls team

Comments

@DHowett-MSFT
Copy link

Describe the bug
The change in #1393 to fix #1309 made TabView always enforce a minimum/maximum size, even in "Size to Content" mode. That's fine, but the default min/max width practically mean that the tabs don't size to their content. Should the defaults be 0 and infinity? Can I as an end user specify Infinite width? Is this mostly a documentation issue?

Steps to reproduce the bug

  1. Use TabView
  2. Add a TabViewItem whose Header is a short string, like ~

Expected behavior
A tab that looks like this crude ASCII sketch:

 _____ 
| ~ x |

Actual behavior

A tab that looks like this crude ASCII sketch:

 _____________ 
| ~         x |

Version Info

NuGet package version:
Microsoft.UI.Xaml.2.3.191007001-prerelease

Windows 10 version Saw the problem?
Insider Build (xxxxx) Yes
May 2019 Update (18362) Yes
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Mobile
Xbox
Surface Hub
IoT
@kmgallahan
Copy link
Contributor

👌 Top notch sketches.

@mdtauk
Copy link
Contributor

mdtauk commented Oct 23, 2019

The default should not be 0. There would need to be a 40 epx minimum width so it can meet the touch target recommendation. Factor in the Close button. And then add a Tab Icon/Loading Progress Ring. and finally adding Tab Text, would all extend the width.

As for a Maximum. I think that should depend on the Tab Mode. Max width when they are all equal. No max by default when it sizes to content. (although text trimming would prevent Tab Titles becoming so unweildly as to become practically useless)

@jevansaks
Copy link
Member

@teaP @stmoy bug or spec issue? We discussed a little bit in email but didn't close.

@jevansaks jevansaks added the help wanted Issue ideal for external contributors label Oct 25, 2019
@teaP
Copy link
Contributor

teaP commented Nov 4, 2019

Reverting my previous change so that sizeToContent wins.

@teaP teaP self-assigned this Nov 4, 2019
@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
@teaP
Copy link
Contributor

teaP commented Nov 12, 2019

Fixed in #1538.

@teaP teaP closed this as completed Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TabView help wanted Issue ideal for external contributors team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

5 participants