Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabView accessibility and tab size fixes #1538

Merged
merged 4 commits into from
Nov 6, 2019
Merged

Conversation

teaP
Copy link
Contributor

@teaP teaP commented Nov 4, 2019

Fixes the following:
#1508: Added name to close button, remove < and > buttons from the accessibility tree as is standard,
#1481: Reverted change that applied min/max sizes to tab in SizeToContent mode.

…lity tree as is standard, reverted change that applied min/max sizes to tab in SizeToContent mode.
@teaP teaP requested a review from a team as a code owner November 4, 2019 18:33
@StephenLPeters
Copy link
Contributor

@jevansaks does looking up resources from code behind via the SharedHelpers::FindResource method work properly?

@jevansaks
Copy link
Member

@jevansaks Jevan Saks FTE does looking up resources from code behind via the SharedHelpers::FindResource method work properly?

Define "properly"? We generally recommend against it since such lookups don't respond to theme changes and they don't do the same walk as even a {StaticResource} would, I think some dictionaries end up getting skipped.

@StephenLPeters
Copy link
Contributor

StephenLPeters commented Nov 5, 2019

@jevansaks Jevan Saks FTE does looking up resources from code behind via the SharedHelpers::FindResource method work properly?

Define "properly"? We generally recommend against it since such lookups don't respond to theme changes and they don't do the same walk as even a {StaticResource} would, I think some dictionaries end up getting skipped.

This is what I was worried about, @teaP is there a way to do this resource management form markup? I guess the control was already doing the lookup from code behind before this change.

@teaP
Copy link
Contributor Author

teaP commented Nov 5, 2019

This is what I was worried about, @teaP Tammy Paine FTE is there a way to do this resource management form markup? I guess the control was already doing the lookup from code behind before this change.

Unfortunately, I don't think so. I need to do math with those numbers. I've definitely already noticed that since it pulls the resources from Application.Current, if you have a scoped resource dictionary in your tree with those resources, it doesn't pick them up (and that's the case for all such lookups where we do this).

Copy link
Member

@kmahone kmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@teaP teaP merged commit cea350d into master Nov 6, 2019
@teaP teaP deleted the user/teaP/TabViewFixes branch November 6, 2019 16:48
@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release note PR that we want to call out in the next release summary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants