-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TabView accessibility and tab size fixes #1538
Conversation
…lity tree as is standard, reverted change that applied min/max sizes to tab in SizeToContent mode.
@jevansaks does looking up resources from code behind via the SharedHelpers::FindResource method work properly? |
Define "properly"? We generally recommend against it since such lookups don't respond to theme changes and they don't do the same walk as even a {StaticResource} would, I think some dictionaries end up getting skipped. |
This is what I was worried about, @teaP is there a way to do this resource management form markup? I guess the control was already doing the lookup from code behind before this change. |
Unfortunately, I don't think so. I need to do math with those numbers. I've definitely already noticed that since it pulls the resources from Application.Current, if you have a scoped resource dictionary in your tree with those resources, it doesn't pick them up (and that's the case for all such lookups where we do this). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the following:
#1508: Added name to close button, remove < and > buttons from the accessibility tree as is standard,
#1481: Reverted change that applied min/max sizes to tab in SizeToContent mode.