-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Revisit back and hamburger buttons placement for LeftMinimal NavigationView #563
Comments
Given the change in landscape and roadmap, the motivations that originally had us introduce the back button into NavView are no longer relevant. Since we're revisiting the back button, we could consider removing it from NavView and giving it back to the shell/titlebar. Thoughts? |
Since it was announced that Sets is not going to happen in Windows - is it time to reconsider the back button in the Shell/Titlebar? Or does the guidance still make sense to put the back button in the apps. If this is the case, making it consistent is a key point. |
I loved the idea of Sets and I'm extremely disappointed it was killed by Microsoft. That said, I do think (especially looking at NavigationView's top-mode) having the back button in the actual control is much better than having it (separately) in the title-bar. With the current design, the back button is clearly visually-related with the rest of the NavigationView and both serve the same functionality, which is navigation. (And I also hope that MS will reconsider and finally give is us the greatness of Sets system-wide in the future.) |
This proposal is very specific to NavigationView, which already includes an Revisiting back button guidance all up continues to be interesting to me, but I don't believe impacts controls in this repo. Similarly, the Sets conversation is out of scope for the WinUI repo. |
The Proposed Fix section of the issue description defines the desired changes. The scope of this proposal is deliberately very narrow. This issue is ready for implementation. |
I linked this proposal on the non-archived Reddit thread - hoping to direct some feedback here! Thanks for picking this up from Reddit, @YuliKl, I'll try to make sure I'm listening there too! |
@SavoySchuler asked me on the Reddit page to leave my feedback here. Here's a copy and paste of what I wrote:
|
Yeah consistency is key here. I guess it would benefit all users 👥 when the back 🔙 button it going back to the title bar. Even now most apps I use have it there. Also its the best way to have consistency with all apps everywhere. |
I used to think the TitleBar was a great place for the back button, but the touch target is too small, and it doesn't work well when extending into the TitleBar area, which is essential to make good looking apps with Acrylic. I think this could be achieved with a PageHeader control, and for controls like NavigationView, Hub, etc to include Back Button support that is there by default, and using a design designed consistently, and for all inbox apps to use this design and Back Button placement. |
To add to what I stated above, app creators shouldn't have the option to pick where the Back button is located, as this choice creates inconsistency. The back button should be treated as a system button like how the close button is treated. As for the designs in the proposal, they look good to me. |
I think that the best position for the backButton is in the App, and the guidelines should be sufficient to create the consistency across Apps. I like the proposed fix. |
I don't have any issues with the touch target of the back button in titlebars. I just tap/click on the top left corner of my screen. As for acrylic in the titlebar area, Settings looks fine with the back button in the titlebar. There are upsides and downsides to having it in the titlebar and in the app. |
To combine the proposal image with yours, This is kinda how the Store currently looks currently. Here's another mock up. |
Thank you for the great discussion everyone! While the scope of this issue is very limited and applies only to NavigationView's back button in Minimal display mode, I did create a more generalized issue to track some of the back button discussion all up: #810 Let's move the back button discussion there to keep our issues on track. Thank you for your help in maintaining some sanity in this repo 😎 |
Nice idea to split this into a few actionable issues, @YuliKl! And thanks for joining us from Reddit, @shaheedmalik, we're excited to have you! Love the mock ups! |
Where does the Hamburger Toggle Icon go when the sidebar is collapsed if inline with the Back Button? What happens when Back navigation becomes visible, moving the Hamburger toggle horizontally is not an ideal experience. Keeping the back button in place and moving the Hamburger Toggle down works in both situations, but the uses of the Titlebar Back Button need to be replaced with the Back Button and header style |
@mdtauk The issue was for when the screen was collapse to minimal size. The pivot menu collapses into the hamburger. Your images doesn't show the expanded view. This is why the hamburger needs to at the higher versus the side. |
@YuliKl , I am not seeing any mention of documentation or sample. Does this require update if so was that done? |
@chigy, I don't believe this requires any doc updates. The new behavior should light up in the Controls Gallery once we switch to using a newer version of WinUI. I don't see anything in the NavigationView article discussing the old behavior. I feel like this is a bug fix. |
@YuliKl Do the images need updating? |
@mdtauk, which images? |
@mdtauk, I don't see any images of the pane opened in Minimal mode, which makes me believe there are no images to update. It's true that in this state, the back button will always perform a close action, never a back navigation. But I honestly feel like this is a very small nuance that will 1) feel natural to users and 2) will not require any action by app developers. So I don't see any value in highlighting this issue's fix in the docs. (But we can have a small celebration on Reddit) |
And I assume one the pane is closed, the normal Back Button will be visible, and behave like it should, navigating back? |
Correct. |
🎉This issue was addressed in #1016, which has now been successfully released as Handy links: |
@RBrid, this change isn't working quite as expected. When I explicitly set my NavigationView's So this code snippet is working correctly: <mux:NavigationView PaneDisplayMode="LeftMinimal">
<mux:NavigationView.MenuItems>
<mux:NavigationViewItem Icon="Play" Content="Menu Item1" Tag="SamplePage1" />
<mux:NavigationViewItem Icon="Save" Content="Menu Item2" Tag="SamplePage2" />
</mux:NavigationView.MenuItems>
<Frame x:Name="contentFrame"/>
</mux:NavigationView> But this code, which should do the same thing as above at narrow window widths, does not work correctly. <mux:NavigationView>
<mux:NavigationView.MenuItems>
<mux:NavigationViewItem Icon="Play" Content="Menu Item1" Tag="SamplePage1" />
<mux:NavigationViewItem Icon="Save" Content="Menu Item2" Tag="SamplePage2" />
</mux:NavigationView.MenuItems>
<Frame x:Name="contentFrame"/>
</mux:NavigationView> |
@YuliKl, I thought the change was intended for LeftMinimal exclusively as seen in the title. |
Love it, thanks! |
…Mode and Minimal DisplayMode for Issue #563.
"#1195 - NavigationView: Fixing visibility of close button in Auto PaneDisplayMode and Minimal DisplayMode" fixed the bug with PaneDisplayMode == Auto. |
It seems like this behavior has reverted back to the problem state. I was going to file Feedback in the Hub for this issue appearing again in the Store app when I noticed it is appearing again in Feedback Hub as well. This issue was previously fixed. It works as intended currently in the XAML Controls Apps still. It doesn't work as intended anymore in Feedback Hub or Microsoft Store, |
The only app that the WinUI team has direct influence over is the Xaml Controls Gallery. I'm not sure whether the other apps' behavior reverted or wasn't fixed, but we can't force them to use the correct version of WinUI with this fix in place. |
Proposal: Revisit back and hamburger buttons placement for LeftMinimal NavigationView
Summary
Currently, when the NavigationView is closed, the control draws the back button in its top left, and the hamburger button immediately to the right of the back button. When the pane is open, the back button disappears and the hamburger button moves over to be positioned in the top left. This transition looks strange and also results in some usability issues: users are forced to move their mouse to press what feels like the same target.
Rationale
This thread is getting a lot of attention on Reddit, making it look like a Feedback Hub error when in fact this behavior is common to all the navigation menus
https://www.reddit.com/r/Windows10/comments/batj1a/who_designed_this_this_is_bad_ui_design/
Similar feedback and sentiment (posted by the same user) about Store app: https://www.reddit.com/r/Windows10/comments/9kh9hl/microsoft_store_poor_ui_who_designed_this/
Functional Requirements
These changes will only apply to NavigationView's Minimal state, the other modes do not need to be updated.
Proposed Fix
IsPaneOpen = False
. IfIsBackButtonVisible = Collapsed
, the back button should not show in the open pane.Release Checklists
Prerelease readiness
Stable release readiness
The text was updated successfully, but these errors were encountered: