Fix TintLuminosityOpacity crash by removing const_cast and passing by non-const #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevansaks
added
the
release note
codendone
approved these changes
Jul 17, 2019
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DependencyProperty codegen for coercion callback was passing the const param through and forcing the callee to receive the parameter by const&, which led to someone using const_cast to try to modify the passed in value. This appeared to work but was over-releasing the incoming object and leaking the new object it had created.
The simplest solution is to make a temporary local to pass in to the coercion callback to remove the need for a const_cast.
I've changed the codegen and updated the build tasks nupkg.
Fixes #1022