Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static resource for corner radius #1078

Merged
merged 7 commits into from
Jul 30, 2019
Merged

Add static resource for corner radius #1078

merged 7 commits into from
Jul 30, 2019

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Jul 18, 2019

Add ControlCornerRadius and OverlayCornerRadius static resource. Update controls to reference the resource values.

@kaiguo kaiguo requested a review from a team as a code owner July 18, 2019 23:41
@kaiguo kaiguo self-assigned this Jul 18, 2019
StephenLPeters
StephenLPeters approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

chrisglein
chrisglein approved these changes Jul 26, 2019
View reviewed changes
dev/ComboBox/ComboBoxHelper.cpp Outdated Show resolved Hide resolved
dev/NavigationView/NavigationView_rs1_themeresources.xaml Show resolved Hide resolved
@kaiguo kaiguo force-pushed the user/kaiguo/add-cornerradius-resource branch from 2c150bf to 28f254a Compare July 29, 2019 21:52
@kaiguo kaiguo force-pushed the user/kaiguo/add-cornerradius-resource branch from 28f254a to d40b43b Compare July 29, 2019 22:39
@kaiguo kaiguo merged commit 944c7d1 into master Jul 30, 2019
@kaiguo kaiguo deleted the user/kaiguo/add-cornerradius-resource branch July 30, 2019 04:51
@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label Jul 30, 2019
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.2.190731001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisglein chrisglein chrisglein approved these changes

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees

@kaiguo kaiguo

Labels
area-Styling release note PR that we want to call out in the next release summary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaiguo @msft-github-bot @StephenLPeters @chrisglein @jevansaks