Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MediaPlayerElement volume button alignment #1292

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Fix MediaPlayerElement volume button alignment #1292

merged 1 commit into from
Sep 10, 2019

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Sep 7, 2019

Fixes #1229

AppBarButton has a label TextBlock underneath the symbol icon. It takes up the space even when no text is set.

Annotation 2019-09-06 170506

Re-templated volume AppBarButton to collapse the label TextBlock. Also updated default CornerRadius of the volume control Flyout.

Before/After comparison:

Annotation 2019-09-06 172020 Annotation 2019-09-06 171939

@kaiguo kaiguo requested a review from a team as a code owner September 7, 2019 00:28
@jevansaks jevansaks added the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Sep 9, 2019
@kaiguo kaiguo merged commit b2accaa into master Sep 10, 2019
@kaiguo kaiguo deleted the user/kaiguo/fix-media-volume-control-style branch September 10, 2019 23:11
@jevansaks jevansaks added release note PR that we want to call out in the next release summary and removed needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) labels Sep 11, 2019
jevansaks pushed a commit that referenced this pull request Sep 11, 2019
@kaiguo @jevansaks
Fix volume button alignment (#1292)
6007851
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.2.190917002 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Sep 19, 2019
Closed
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.3.191007001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jevansaks jevansaks jevansaks approved these changes

Assignees
No one assigned
Labels
area-Styling release note PR that we want to call out in the next release summary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controls on MediaPlayerElement MTC Volume flyout are not vertically aligned
3 participants
@kaiguo @msft-github-bot @jevansaks