Add key names to default control styles

[kaiguo]

Fixes #1260.

Added key names to default control styles so they can support BasedOn styles like below.

<Style x:Key="MyComboBoxStyle" TargetType="ComboBox" BasedOn="{StaticResource DefaultComboBoxStyle}">
    ...
</Style>

[dpaulino]

@kaiguo quick question, would apps that consume WinUI be able to create styles based on these styles?

[jevansaks]

That's the idea! If you want to give it a spin you can try the nupkg from the PR build. Try this link?

https://dev.azure.com/ms/_apis/resources/Containers/3023874?itemPath=drop%2FMicrosoft.UI.Xaml.2.3.190910001-prerelease.nupkg

[kaiguo]

Yes, apps consuming WinUI should be able to use these styles. The link Jevan posted above has the latest changes, you can give that a try : )

[dpaulino]

Just tried it and indeed it works! Thanks.

Will there be a docs page or something that lists all the style key names so that we know what key name to put in the BasedOn style property when creating our own styles?

[mdtauk]

Just tried it and indeed it works! Thanks.

Will there be a docs page or something that lists all the style key names so that we know what key name to put in the BasedOn style property when creating our own styles?

As well as docs, will the Design Time experience allow creating copies of all templates in VS or Blend?

[kaiguo]

As well as docs, will the Design Time experience allow creating copies of all templates in VS or Blend?

Yes, you should be able to right click the control on design surface and do "Edit Template -> Edit a Copy"

[kaiguo]

@jevansaks who should we ping for doc updates?

[jevansaks]

We can just make the changes, but @kikisaints @chigy should recommend which doc we would add it to.

[kikisaints]

My hunch is that it would go here: controls and patterns - buttons under the examples page as a caveat or additional example on how to extend our button control.

Might also be good to mention some of the other styles available for button in generic.xaml, like ButtonRevealStyle..

@chigy for thoughts

[chigy]

@kikisaints , are these limited to button? Looks like they could be any control style to BasedOn?

[mdtauk]

Why are these brushes using hardcoded values, instead of reusable resources?

<SolidColorBrush x:Key="FlipViewButtonBackgroundThemeBrush" Color="#59D5D5D5" /> 
<SolidColorBrush x:Key="FlipViewButtonBorderThemeBrush" Color="#59D5D5D5" /> 
<SolidColorBrush x:Key="FlipViewButtonForegroundThemeBrush" Color="#99000000" /> 
<SolidColorBrush x:Key="FlipViewButtonPointerOverBackgroundThemeBrush" Color="#F0D7D7D7" /> 
<SolidColorBrush x:Key="FlipViewButtonPointerOverBorderThemeBrush" Color="#9EC1C1C1" /> 
<SolidColorBrush x:Key="FlipViewButtonPointerOverForegroundThemeBrush" Color="#FF000000" /> 
<SolidColorBrush x:Key="FlipViewButtonPressedBackgroundThemeBrush" Color="#BD292929" /> 
<SolidColorBrush x:Key="FlipViewButtonPressedBorderThemeBrush" Color="#BD292929" /> 
<SolidColorBrush x:Key="FlipViewButtonPressedForegroundThemeBrush" Color="#FFFFFFFF" />

[kaiguo]

I'm not sure, some of them might not be in the theme colors (There's only ~25 system colors https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/xaml-theme-resources#light-and-dark-theme-colors). I agree we should use the reusable resource if there's one available.

[jevansaks]

We've got a separate issue discussing that and that isn't the goal of this change so I don't want to dilute this PR with unrelated changes.

[msft-github-bot]

🎉Microsoft.UI.Xaml v2.2.190917002 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official Nuget Release

[msft-github-bot]

🎉Microsoft.UI.Xaml v2.3.191007001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official Nuget Release