Fix SplitButton reveal style, Closes #1310 #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chingucoding you are incredible! Thanks again. |
jevansaks
added
release note
jevansaks
approved these changes
Sep 11, 2019
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
No problem. It's the least I can do, since I was the person to introduce this bug in the first place. 😅 |
jevansaks
pushed a commit
that referenced
this pull request
Sep 12, 2019
jevansaks
removed
the
needs-cherrypicktorelease
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug with the SplitButton Reveal style where closing the flyout would remove the reveal style from the chevron button.
Side note: Clicking the left button had the same effect on the left button.
Motivation
Closes #1310 .
Screenshot