Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with textbox clipping under small width and height #1344

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Fix bug with textbox clipping under small width and height #1344

merged 2 commits into from
Sep 17, 2019

Conversation

marcelwgn
Copy link
Collaborator

Summary

Fix a bug with the TextBox component where it would start clipping when width and height is set to small values.

Motivation

Fixes #641.

Screenshots

image

@marcelwgn marcelwgn requested a review from a team as a code owner September 17, 2019 10:40
@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label Sep 17, 2019
@jevansaks
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kaiguo
kaiguo approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@kaiguo kaiguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kaiguo kaiguo merged commit a65422c into microsoft:master Sep 17, 2019
@adrientetar
Copy link

@chingucoding Thanks! In the same vein there's #689 if you want to look at that one.

@marcelwgn
Copy link
Collaborator Author

@chingucoding Thanks! In the same vein there's #689 if you want to look at that one.

@adrientetar I will take a look at it, thank you for pointing that issue out.

@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.3.191007001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Oct 7, 2019
Closed
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.3.191129002 has been released which incorporates this pull request.:tada:

Handy links:

@marcelwgn marcelwgn deleted the textbox-clipping-bug branch April 16, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiguo kaiguo kaiguo approved these changes

Assignees

@kaiguo kaiguo

Labels
release note PR that we want to call out in the next release summary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextBox right border is clipped w/ smaller Width set
5 participants
@marcelwgn @jevansaks @adrientetar @msft-github-bot @kaiguo