Fix TreeViewNode content display #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevansaks
reviewed
Sep 23, 2019
jevansaks
approved these changes
Sep 24, 2019
jevansaks
added
the
release note
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made TreeViewNode stringable in order to show string content correctly. TreeViewNode checks for ICustomPropertyProvider and IStringable interfaces to convert Content to String. This works in C# app, but in C++, string content is passed in as hstring (neither ICustomPropertyProvider nor IStringable), added "unbox_value" to correctly handle that. Also added a test in NugetPackageTestAppCX.