Fix issue with TabView crashing in a NavigationCacheMode=Required page #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jevansaks
reviewed
Oct 23, 2019
teaP
reviewed
Oct 23, 2019
teaP
reviewed
Oct 24, 2019
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Commenter does not have sufficient privileges for PR 1482 in repo microsoft/microsoft-ui-xaml |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
teaP
approved these changes
Oct 29, 2019
jevansaks
changed the title
|
Nit: I edited the title of this PR to be more descriptive. |
jevansaks
added
the
release note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
TabViewis in aPagewhich hasNavigationCacheMode = "Required", it'd cause the app to crash. Because, in theLoadedevent of theListView, the previous code would always add the currentTabItemsof theTabView, but it is necessary to check whether theItemsbeing added have already been added before. As it didn't check that, it would crash in the second loaded event.Fixes #1245
How Has This Been Tested?
I used the MUXControlTestApp to test the changes. I set the
NavigationCacheMode="Required"of the TabViewPage and navigated back and forth to ensure it doesn't crash anymore, as it would before.