-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where the "More" text would get clipped with text scaling > 200% #1942
Fix bug where the "More" text would get clipped with text scaling > 200% #1942
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@chingucoding Looks like ColorPickerTests.VerifyVisualTree test needs to be updated. |
Thanks for pointing that out! I have updated the visual tree verification files. Do you by any chance know where the numbering comes from (and why in the pipeline drop, there was a ColorPicker-6.xml and a ColorPicker-7.xml file)? CC @kaiguo |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The numbers at the end of the file name indicate the sdk versions that the master file will checked against. |
Ah I see. Seems like the pipeline failed because of the "ColorPicker-6.xml" file, should I remove it since it was not present beforehand? |
@chingucoding this doc should have the steps you need to take to update the master files. |
Hmm, I am not quite sure if adding the "ColorPicker-6.xml" was a great idea on my side. I have removed it (and thanks for the link to the doc!). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Set height of the "More" button to a minimum instead of forced value.
Motivation and Context
Fixes #1934
How Has This Been Tested?
Tested manually with text scaling > 200%.
Screenshots (if appropriate):