Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where the "More" text would get clipped with text scaling > 200% #1942

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

marcelwgn
Copy link
Collaborator

Description

Set height of the "More" button to a minimum instead of forced value.

Motivation and Context

Fixes #1934

How Has This Been Tested?

Tested manually with text scaling > 200%.

Screenshots (if appropriate):

image

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Feb 5, 2020
@kmahone
Copy link
Member

kmahone commented Feb 5, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj
Copy link
Contributor

ranjeshj commented Feb 6, 2020

@chingucoding Looks like ColorPickerTests.VerifyVisualTree test needs to be updated.

@marcelwgn
Copy link
Collaborator Author

@chingucoding Looks like ColorPickerTests.VerifyVisualTree test needs to be updated.

Thanks for pointing that out! I have updated the visual tree verification files.

Do you by any chance know where the numbering comes from (and why in the pipeline drop, there was a ColorPicker-6.xml and a ColorPicker-7.xml file)?

CC @kaiguo

@kmahone
Copy link
Member

kmahone commented Feb 6, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

@chingucoding Looks like ColorPickerTests.VerifyVisualTree test needs to be updated.

Thanks for pointing that out! I have updated the visual tree verification files.

Do you by any chance know where the numbering comes from (and why in the pipeline drop, there was a ColorPicker-6.xml and a ColorPicker-7.xml file)?

CC @kaiguo

The numbers at the end of the file name indicate the sdk versions that the master file will checked against.

@marcelwgn
Copy link
Collaborator Author

The numbers at the end of the file name indicate the sdk versions that the master file will checked against.

Ah I see.

Seems like the pipeline failed because of the "ColorPicker-6.xml" file, should I remove it since it was not present beforehand?

@kaiguo
Copy link
Contributor

kaiguo commented Feb 6, 2020

Seems like the pipeline failed because of the "ColorPicker-6.xml" file, should I remove it since it was not present beforehand?

@chingucoding this doc should have the steps you need to take to update the master files.

@StephenLPeters StephenLPeters added team-Controls Issue for the Controls team area-ColorPicker and removed needs-triage Issue needs to be triaged by the area owners labels Feb 6, 2020
@marcelwgn
Copy link
Collaborator Author

@chingucoding this doc should have the steps you need to take to update the master files.

Hmm, I am not quite sure if adding the "ColorPicker-6.xml" was a great idea on my side. I have removed it (and thanks for the link to the doc!).

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone kmahone merged commit 7583b0c into microsoft:master Feb 11, 2020
@marcelwgn marcelwgn deleted the fix-colorpicker-morebuttonclipped branch May 15, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ColorPicker team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color Picker Clipped Text with Text Scaling
6 participants