-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NavigationViewItemSeparator lightweight styling theme resources #2206
Merged
anawishnoff
merged 6 commits into
microsoft:master
from
Felix-Dev:user/FelixDev/navigationview-separator-styling
Apr 6, 2020
Merged
Add NavigationViewItemSeparator lightweight styling theme resources #2206
anawishnoff
merged 6 commits into
microsoft:master
from
Felix-Dev:user/FelixDev/navigationview-separator-styling
Apr 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Felix-Dev can you please merge with master which includes some stability fixes for the PR pipeline ? |
@ranjeshj Done. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
suggested changes
Apr 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
StephenLPeters
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ojhad
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds lightweight styling theme resources for the NavigationViewItemSeparator to enable easy customization of its default appearance without having to retemplate it. The following theme resources have been added (each using the current default values):
Foreground:
Margin:
Thickness:
Motivation and Context
Closes #2139.
How Has This Been Tested?
Tested visually.
Screenshots (if appropriate):
Top mode
First separator from the left uses default styling, second separator uses the following theme resources:
Margin:
Left mode (expanded + compact)
First separator from the top uses default styling, second separator uses the following resources:
Margin (same for both left expanded and left compact mode)