Fix FlowLayout LineSpacing and MinItemSpacing #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
msft-github-bot
added
the
needs-triage
|
Can you please add a test for this? :) |
|
I believe the modified test already covers this in some way? It would fail without this fix. |
marcelwgn
approved these changes
Apr 13, 2020
ranjeshj
approved these changes
Apr 13, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
added
area-ItemsRepeater
team-Controls
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
FlowLayout'sLineSpacingandMinItemSpacingand make them consistent withUniformGridLayout.Motivation and Context
The
ScrollOrientation()originally used inLineSpacing()andMinItemSpacing()always evaluated toScrollOrientation::Vertical, and the expressions after the?operator were reversed.How Has This Been Tested?
Modified existing test.