NavigationView ItemInvoked returning incorrect item fix #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-NavigationView
marcelwgn
reviewed
Jun 16, 2020
Felix-Dev
reviewed
Jun 24, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please merge with master to pick up the GLS const enforcement change and make sure you don't have any build failures from that. |
|
@ojhad This looks blocked by the merge conflict |
ojhad
force-pushed
the
user/diojha/iteminvokefix
branch
from
de3e8e4 to
ffa9e06
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the scenario where MenuItemTemplate/MenuItemTemplateSelector returns a
UIElementthat is not derived fromNavigationViewItemBase, the ItemInvoked callback returns theUIElementinstead of the expected data item provided viaMenuItemsSource.This is because in the
ItemsRepeaterNV implementation, we internally wrap thisUIElementin aNavigationViewItem. This is done by setting the content property of aNavigationViewItemto the returnedUIElement. This breaks expectation from theListViewimplementation as the content property should be set to the actual data item.Fixed this issue by updating the wrapping logic to pass down the content and ItemTemplate down to the NavigationViewItem's content presenter to resolve.
Note:
I still have to figure out the best way to recycle the returned
UIElement, so for now I left it as a todo. Depending on when I find a good way to do this, I will either update this PR or file a new issue.Motivation and Context
Fixes #2520
How Has This Been Tested?
Added new interaction test