Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabview: Fix issue with newly added items not behaving according to TabViews WidthMode #2752

Merged

Conversation

marcelwgn
Copy link
Collaborator

Description

Added code to ensure that the newly added TabView items know the parents TabView WidthMode and ensure that we update the TabViewItems update their compact sizing visual states on apply template.

Motivation and Context

Fixes #2711 Coincidentally, this also fixes #2724

How Has This Been Tested?

Fixed existing API test that already "tested" this.

Screenshots (if appropriate):

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jun 25, 2020
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TabView team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabView ignores TabWidthMode set from markup [TabView] Compact sizing does not apply to newly-added items
3 participants