Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treeview: Fix Background API not being applied to TreeView UI. #3016

Conversation

Felix-Dev
Copy link
Contributor

Description

This PR fixes the TreeView.Background API not being applied to the TreeView UI.

While adding an API test, I also cleaned up the TreeView API tests code to use the VisualTreeUtils.FindVisualChildByName() method instead of a local implementation.

Motivation and Context

Fixes #3012.

How Has This Been Tested?

Tested visually and added API test.

Screenshots:

<TreeView Background="BlueViolet" 
    Width="200" Height="200"/>

image

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jul 30, 2020
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters added area-Styling area-TreeView team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jul 30, 2020
@StephenLPeters StephenLPeters merged commit e51202a into microsoft:master Jul 31, 2020
@Felix-Dev Felix-Dev deleted the user/Felix-Dev/treeview-background-fix branch July 31, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeView does not respect the background property
3 participants