-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RadioButtons: Wrap custom ItemTemplate in a RadioButton if required #3194
Merged
StephenLPeters
merged 5 commits into
microsoft:master
from
Felix-Dev:user/Felix-Dev/radiobuttons-itemtemplate-issue-fix
Sep 8, 2020
Merged
RadioButtons: Wrap custom ItemTemplate in a RadioButton if required #3194
StephenLPeters
merged 5 commits into
microsoft:master
from
Felix-Dev:user/Felix-Dev/radiobuttons-itemtemplate-issue-fix
Sep 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
Issue needs to be triaged by the area owners
label
Aug 25, 2020
YuliKl
added
area-RadioButtons
team-Controls
Issue for the Controls team
and removed
needs-triage
Issue needs to be triaged by the area owners
labels
Aug 25, 2020
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@Felix-Dev The pipeline fix just went in, could you please merge master into this PR? |
@StephenLPeters Merged with master. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Felix-Dev
deleted the
user/Felix-Dev/radiobuttons-itemtemplate-issue-fix
branch
September 8, 2020 23:17
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where a custom ItemTemplate specified for the RadioButtons control would not wrap that template in a RadioButton if it wasn't a RadioButton. This made the RadioButtons control basically unusuable if developers did not explicitly specify a
RadioButton
as the root of the ItemTemplate (no (mutually-exclusive) selection was possible).We now wrap the ItemTemplate in a
RadioButton
if it isn't already aRadioButton
. If the user set a RadioButton as the root of the ItemTemplate we take it as is and perform no wrapping. This will make sure user-providedRadioButton
customizations won't be lost.@kikisaints As part of #3159 providing better documention for the
RadioButton
customization aspect was identified as a work item. My curent thinking is to create a new sub-section titled "Customizing the radio button appearance" here. This section will show you can explicitly set aRadioButton
as the root of the ItemTemplate to change its appearance:I would also like to create a reference on the RadioButtons API documentation page to the RadioButton control overview page as can be seen for other controls like the TabView (see the green info block).
I would work on this once this PR has been merged and would tag you then so you can give further input/review. For now, you can already comment on how you view the overview I gave above, if you like.
Also @ranjeshj FYI.
Motivation and Context
Fixes #3159.
How Has This Been Tested?
Tested visually and added API test.
Screenshots:
The following C# and XAML markup gives us the UI shown below: