Add support for Content Alignment inside AutoSuggestBox #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
StephenLPeters
added
area-AutoSuggestBox
team-Controls
marcelwgn
reviewed
Oct 7, 2020
|
@chingucoding @Felix-Dev added it to the default text box:) |
|
@beervoley You will need to update the visual verification files in order to resolve these test failures, reach out to me if you need help resolving that. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
@beervoley can you merge master into this branch? that will pick up the fix for the visual verifications files that went in today then we can rerun the pipeline to get the verification files you need, and rerun with those to get a clear test pass :) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
approved these changes
Dec 14, 2020
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 20, 2020
This was referenced Jan 6, 2021
Closed
This was referenced Mar 23, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds binding of
VerticalContentAlignmentandHorizontalContentAlignmentto AutoSuggestBox.Motivation and Context
This PR fixes #3284
Before, it was impossible to set the content alignment inside AutoSuggestBox using the appropriate arguments in the constructor. This PR makes it possible to set content alignment to the desired values via:
<AutoSuggestBox VerticalContentAlignment="Bottom" HorizontalContentAlignment="Left"/>If the user doesn't provide the content alignment values, the content will be in the left top corner of the box.
How Has This Been Tested?
Manually tested the changes (see the attached screenshot).
Screenshots (if appropriate):
Content position without providing any content alignment properties:
Content position with
VerticalContentAlignment = "Bottom"andHorizontalContentAlignment = "Center":