TeachingTips display correctly when IsOpen is set early. #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are missing template parts because of retemplating or attempts to open at unplanned points. Also delay the opening of the tip when IsOpen is set to true until after the next rendering tick to make setting isOpen from markup work. Finally add a copy of the GSL headers to the project so we can utilize these helpers.
jevansaks
reviewed
Apr 26, 2019
jevansaks
reviewed
Apr 26, 2019
jevansaks
reviewed
Apr 26, 2019
jevansaks
reviewed
Apr 26, 2019
jevansaks
reviewed
Apr 26, 2019
jevansaks
reviewed
Apr 26, 2019
jevansaks
reviewed
Apr 26, 2019
jevansaks
reviewed
Apr 26, 2019
-Remove the GSL nuget dependency -Add a TrySetCenterPoint -Move StrictThis declaration to the lambda capture.
jevansaks
added
the
needs-cherrypicktorelease
jevansaks
removed
the
needs-cherrypicktorelease
jevansaks
pushed a commit
that referenced
this pull request
May 30, 2019
* Clean up some teaching tip code to ensure that we don't crash when we are missing template parts because of retemplating or attempts to open at unplanned points. Also delay the opening of the tip when IsOpen is set to true until after the next rendering tick to make setting isOpen from markup work. Finally add a copy of the GSL headers to the project so we can utilize these helpers. * Remove a commented out line of code * Undo changes to dispatch helper. * Delete some unused header defs * Respond to CR feedback. -Remove the GSL nuget dependency -Add a TrySetCenterPoint -Move StrictThis declaration to the lambda capture.
|
🎉 Handy links: |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When IsOpen is set to true for targeted tips which have targets which are not yet fully loaded we would display in the incorrect position because TransformToVisual does not return a proper value.
When IsOpen is set to true and we haven't applied the TeachingTip template, and are not able to synchronously apply the template the tip would crash because we assumed the presence of certain template parts.
This change fixes both of these issues by delaying the TeachingTip's opening and closing until after the CompositionRendering event. We also make less assumptions about the presence of template parts.
Finally I've included the newest GSL headers for use across the project.